Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for webpack-dev-server 3.1.11 #1795

Merged
merged 2 commits into from
May 13, 2019
Merged

Bugfix for webpack-dev-server 3.1.11 #1795

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c10616
adding disableHostCheck flag to webpack-dev-server because 3.1.11 int…
jlieb10 May 13, 2019
2faec7b
Merge branch 'master' into jtl-webpack-dev-server-bugfix
joelochlann May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion support-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"build-ssr": "webpack --config webpack.ssr.js && node scripts/ssrScript.js",
"build-prod": "npm-run-all clean validate test storybook-static 'webpack --config webpack.prod.js --env.prod'",
"webpack": "webpack",
"webpack-dev-server": "webpack-dev-server --config webpack.dev.js --port 9211 --public support.thegulocal.com",
"webpack-dev-server": "webpack-dev-server --config webpack.dev.js --port 9211 --public support.thegulocal.com --disable-host-check",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add a comment with a link to the issue jonny was looking at?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnduffell comments are not supported in json files so we settled for a PR with the documentation 😢

"devrun": "npm-run-all clean webpack-dev-server",
"test": "echo 'Running JS tests' && jest",
"stat": "yarn build-prod && webpack-bundle-analyzer public/compiled-assets/stats.json",
Expand Down