Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http4s client: prefix identity with Predef #236

Merged
merged 2 commits into from
Apr 16, 2019
Merged

http4s client: prefix identity with Predef #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ade90d7
http4s client: prefix identity with Predef
dsilvasc Apr 14, 2019
a51f6ec
http4s client identity
blast-hardcheese Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/codegen/src/main/scala/com/twilio/guardrail/generators/Http4sClientGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ object Http4sClientGenerator {
resp.value.fold[Case](
p"case ${resp.statusCodeName}(_) => effect.pure($responseCompanionTerm.$responseTerm)"
) { _ =>
p"case ${resp.statusCodeName}(resp) => ${Term.Name(s"$methodName${resp.statusCodeName}Decoder")}.decode(resp, strict = false).fold(throw _, identity).map($responseCompanionTerm.$responseTerm)"
p"case ${resp.statusCodeName}(resp) => ${Term.Name(s"$methodName${resp.statusCodeName}Decoder")}.decode(resp, strict = false).fold(throw _, Predef.identity).map($responseCompanionTerm.$responseTerm)"
}
} :+ p"case resp => effect.raiseError(UnexpectedStatus(resp.status))"
// Get the response type
Expand Down
2 changes: 1 addition & 1 deletion modules/codegen/src/test/scala/tests/generators/http4s/BasicTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class BasicTest extends FunSuite with Matchers with SwaggerSpecRunner {
val req = Request[F](method = Method.GET, uri = Uri.unsafeFromString(host + basePath + "/baz"), headers = Headers(allHeaders))
httpClient.fetch(req)({
case Ok(resp) =>
getBazOkDecoder.decode(resp, strict = false).fold(throw _, identity).map(GetBazResponse.Ok)
getBazOkDecoder.decode(resp, strict = false).fold(throw _, Predef.identity).map(GetBazResponse.Ok)
case resp =>
effect.raiseError(UnexpectedStatus(resp.status))
})
Expand Down
2 changes: 1 addition & 1 deletion modules/codegen/src/test/scala/tests/generators/http4s/client/DefaultParametersTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class DefaultParametersTest extends FunSuite with Matchers with SwaggerSpecRunne
val req = Request[F](method = Method.GET, uri = Uri.unsafeFromString(host + basePath + "/store/order/" + Formatter.addPath(orderId) + "?" + Formatter.addArg("defparm_opt", defparmOpt) + Formatter.addArg("defparm", defparm)), headers = Headers(allHeaders))
httpClient.fetch(req)({
case Ok(resp) =>
getOrderByIdOkDecoder.decode(resp, strict = false).fold(throw _, identity).map(GetOrderByIdResponse.Ok)
getOrderByIdOkDecoder.decode(resp, strict = false).fold(throw _, Predef.identity).map(GetOrderByIdResponse.Ok)
case BadRequest(_) =>
effect.pure(GetOrderByIdResponse.BadRequest)
case NotFound(_) =>
Expand Down