Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copypasta in JacksonGenerator causing maps to be lists #281

Merged
merged 1 commit into from
May 4, 2019
Merged

Fix copypasta in JacksonGenerator causing maps to be lists #281

merged 1 commit into from
May 4, 2019

Conversation

kelnos
Copy link
Member

@kelnos kelnos commented May 4, 2019

Also parse both in a safer way that makes it more clear where errors lie.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

blast-hardcheese
blast-hardcheese approved these changes May 4, 2019
View reviewed changes
Copy link
Member

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kelnos kelnos mentioned this pull request May 4, 2019
Closed
@kelnos
Copy link
Member Author

kelnos commented May 4, 2019

right? i feel super dumb now.

@kelnos kelnos merged commit 11d41ab into guardrail-dev:master May 4, 2019
@kelnos kelnos deleted the fix-jackson-maps branch May 4, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blast-hardcheese blast-hardcheese blast-hardcheese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelnos @blast-hardcheese