Fix discriminator filter in circe protocol trait generation #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
approved these changes
May 24, 2019
kelnos
force-pushed
the
fix-circe-trait-discriminator-filter
branch
from
807f5e6
to
0f7a724
Compare
kelnos
force-pushed
the
fix-circe-trait-discriminator-filter
branch
from
001ea72
to
a594a2d
Compare
|
Edit: Sorry I tought this was 2020, we need to look better what might be the issue we are having. |
|
@rtfpessoa Feel free to open a new issue -- #447 is now somewhat long standing and the potential cause of some unfortunate bugs. I haven't been able to get to it yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why PR validation didn't catch this. (And I bet this showed up as a warning, but I missed it :( ).
Contributing to Twilio