Don't generate an inline object for objects with no properties #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core doesn't really know how to emit objects like that (so it doesn't, and we end up with a compile error when building the generated classes). At any rate, if there's a bare object type without any properties, our assumption is that the user is expected to populate it with arbitrary key/value pairs (sorta like a map, but I guess they get more freedom for keys?), so in this case we should just use objectType() (io.cire.Json or Jackson JsonNode).
kelnos
force-pushed
the
fix-anonymous-additional-properties
branch
from
af409f7
to
bc2df0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core doesn't really know how to emit objects like that (so it doesn't, and we end up with a compile error when building the generated classes). At any rate, if there's a bare
objecttype without anyproperties, our assumption is that the user is expected to populate it with whatever data is applicable: arbitrary key/value pairs, primitive types, whatever; so in this case we should just use
objectType()(io.cire.Jsonor JacksonJsonNode).Issue introduced in #356 -- unfortunately at the time we didn't have a specific test for this, so no surprise we didn't catch it.
Contributing to Twilio