Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labels.json #692

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Update labels.json #692

merged 2 commits into from
Nov 15, 2024

Conversation

guibranco
Copy link
Owner

@guibranco guibranco commented Nov 15, 2024

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

☒️ Does this introduce a breaking change?

  • Yes
  • No

β„Ή Additional Information

Summary by CodeRabbit

  • New Features
    • Introduced a new "do-not-merge" label for pull requests to prevent automatic merging, enhancing the labeling system.

Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

Walkthrough

A new entry has been added to the "context" section of the labels.json file. This entry includes properties such as color, description, text, and text with an icon, specifically designed to indicate that automatic merging of pull requests is restricted. This change enhances the labeling system for pull requests.

Changes

File Change Summary
Src/config/labels.json Added new entry in "context": {"color": "#FF0000", "description": "Prevents automatic merging of pull requests (gstraccini-bot)", "text": "do-not-merge", "textWithIcon": "🫷 do-not-merge"}

Possibly related PRs

  • Update labels.jsonΒ #638: This PR modifies the labels.json file, which is directly related to the changes made in the main PR that also involves adding a new entry to the same file.

Suggested reviewers

  • gstraccini

🐰 In the meadow, bright and red,
A label blooms, where paths are tread.
"Do not merge," it softly sings,
A gentle warning, oh, the joy it brings!
With icons bright and colors bold,
Our pull requests, a tale to be told! 🌼


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between f4297e8 and 4e0ff0b.

πŸ“’ Files selected for processing (1)
  • Src/config/labels.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Src/config/labels.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@guibranco guibranco enabled auto-merge (squash) November 15, 2024 12:31
@gstraccini gstraccini bot added the β˜‘οΈ auto-merge Automatic merging of pull requests (gstraccini-bot) label Nov 15, 2024
@gstraccini gstraccini bot requested a review from gstraccini November 15, 2024 12:31
Copy link

deepsource-io bot commented Nov 15, 2024

Here's the code health analysis summary for commits 175ceeb..4e0ff0b. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Docker LogoDockerβœ…Β SuccessView CheckΒ β†—
DeepSource PHP LogoPHPβœ…Β SuccessView CheckΒ β†—
DeepSource Secrets LogoSecretsβœ…Β SuccessView CheckΒ β†—
DeepSource SQL LogoSQLβœ…Β SuccessView CheckΒ β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2024
Copy link

JSON and YAML Validation Results

JSON Validation Results

  • βœ… File(s) Passed: 5
  • ❌ File(s) Failed: 1
  • ⏭️ File(s) Skipped: 0

Violations:

[
  {
    "file": "Src/config/labels.json",
    "errors": [
      {
        "path": null,
        "message": "Invalid JSON"
      }
    ]
  }
]

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
Src/config/labels.json (1)

19-19: Consider using a more widely supported emoji.

The 🫷 emoji (U+1FAF7) is relatively new and might not render correctly in all environments. Consider using a more universally supported emoji like β›”, 🚫, or πŸ›‘ which better convey the "do not" meaning.

Example:

-            "textWithIcon": "🫷 do-not-merge",
+            "textWithIcon": "🚫 do-not-merge",
πŸ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 175ceeb and f4297e8.

πŸ“’ Files selected for processing (1)
  • Src/config/labels.json (1 hunks)
πŸ”‡ Additional comments (1)
Src/config/labels.json (1)

15-20: LGTM! Well-structured label definition.

The new label is properly formatted and follows the existing pattern. The red color and clear description effectively communicate its purpose of preventing automatic merging.

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

Infisical secrets check: βœ… No secrets leaked!

πŸ’» Scan logs
12:47PM INF scanning for exposed secrets...
12:47PM INF 645 commits scanned.
12:47PM INF scan completed in 152ms
12:47PM INF no leaks found

@guibranco guibranco merged commit e37c5d0 into main Nov 15, 2024
20 checks passed
@guibranco guibranco deleted the guibranco-patch-1 branch November 15, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
β˜‘οΈ auto-merge Automatic merging of pull requests (gstraccini-bot) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants