Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgcrypt: fixes process() not returning std:nullopt when main loop fails #4

Merged
merged 1 commit into from
May 25, 2019
Merged

libgcrypt: fixes process() not returning std:nullopt when main loop fails #4

merged 1 commit into from
May 25, 2019

Conversation

s-zanella
Copy link
Contributor

process() could return a value even when the main encryption/decryption loop failed.

This causes e.g. encryption to return a truncated ciphertext when the output buffer is too short and the loop iterates at least once, setting ret.

@guidovranken guidovranken merged commit 8b1c4d8 into guidovranken:master May 25, 2019
@guidovranken
Copy link
Owner

Thanks!

@olivieradjonyo olivieradjonyo mentioned this pull request Mar 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-zanella @guidovranken