Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added download_data_local.py and updated 5.1 Filtering #3

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

adiezsanchez
Copy link
Contributor

Hi Guillaume,

As I am running through the notebooks I am updating the code and explanations here and there to clarify a few things. I.e. some parameter names have changed in skimage.filters.median from "selem" to "footprint" in the latest versions of scikit-image.

I created a new download_local_data.py file for people like me that run the notebooks in their own computer so the Data is downloaded and extracted into the directory where the rest of the notebooks import the image files from.

Please discard what you deem unnecessary :)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@guiwitz
Copy link
Owner

guiwitz commented Jul 25, 2023

Hi @adiezsanchez. Any reason you closed this PR? Still happy to include your updates, unless there's another problem?

@adiezsanchez
Copy link
Contributor Author

adiezsanchez commented Jul 25, 2023

Hi @guiwitz felt like it was a lot of changes at once 😅. Maybe I can make multiple smaller commits? I will reopen this anyways so you can check it 😊👍. The segmentation of nuclei was picking up a bit of extra crap though (will need to revisit that).

@adiezsanchez adiezsanchez reopened this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants