chore!: Normalize repository, dropping node <10.13 support #16
Conversation
sttk
force-pushed
the
chore-normalize-repository
branch
from
405da19 to
2a37966
Compare
package.json
Outdated
| "test": "mocha --async-only", | ||
| "cover": "nyc --reporter=lcov --reporter=text-summary npm test", | ||
| "coveralls": "npm run cover && istanbul-coveralls", | ||
| "cover": "nyc mocha --async-only", |
There was a problem hiding this comment.
I think this is wrong. We move the nyc into the "test" script, right?
There was a problem hiding this comment.
Got it. I'll modify it.
package.json
Outdated
| "expect": "^27.3.1", | ||
| "mocha": "^8.4.0", | ||
| "nyc": "^15.1.0", | ||
| "v8flags": "^3.2.0" |
There was a problem hiding this comment.
We'll need to release this and update to the next major
package.json
Outdated
| "respawn": "node test/bin/respawner --harmony test", | ||
| "nospawn": "node test/bin/respawner test" |
There was a problem hiding this comment.
I think they aren't used, too. I'll remove them.
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
|
@phated After using For compatibility of the cache file, shouldn't we keep this separator underscore? And Node.js>=v10 also accepts both dash and underscore as v8 option's separator. |
|
Sorry, we should use dash and underscore separately depending on |
|
@sttk this will be a semver major version increase, so we can stop supporting the snake_case flags. Even though node still supports these flags, we only supported them because old versions of node did not support hyphens. |
|
@phated I got it. I'll remove the codes which replace dashes in v8 flags to underscores. |
|
@phated I've modified what you pointed out. Please review them. |
|
@phated Thank you for merging! |
This PR updates this project:
I separated testing to
npm testandnpm run coverbecause one test case does not work on nyc.Closes #15