Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove moveDrive logic in test #252

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: remove moveDrive logic in test #252

merged 1 commit into from
Jan 25, 2024

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Jan 21, 2024

Resolves #247.

This moveDrive logic was implemented to avoid an error in a test case. Now, that test case passes without this logic.

@sttk sttk requested a review from phated January 21, 2024 02:28
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phated phated merged commit 0a35a9e into gulpjs:master Jan 25, 2024
18 checks passed
@sttk sttk deleted the issue247 branch January 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check moveDrive logic on Windows with use of exec cwd
2 participants