Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #1663

Closed
wants to merge 1 commit into from
Closed

Update CI #1663

wants to merge 1 commit into from

Conversation

adam-moss
Copy link

Update Travis with the latest version of node, major version releases of node, and iojs.

@phated
Copy link
Member

phated commented May 16, 2016

Our only supported platforms will be node 0.10, 0.12, 4, 5 and 6; we will not be supporting specific version of node like 4.2 nor iojs releases.

@adam-moss
Copy link
Author

Updated as per comment.

@@ -1,10 +1,12 @@
sudo: false
language: node_js
node_js:
- "0.10"
- "0.12"
- "node"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for node if all the versions are specified. We want to be explicit when we support something new (e.g. node 7 when it comes out) but right now this just does another run of node 6.

@adam-moss
Copy link
Author

adam-moss commented May 17, 2016

Updated 😄

I had included node as that is the replacement for stable which was already in.

@phated
Copy link
Member

phated commented May 24, 2016

@adam-moss please remove the node line. Since we are being specific about the versions we are supporting on CI, I don't want a replacement for stable. Thanks

Update Travis with supported versions of node.
@adam-moss
Copy link
Author

Done.

@phated
Copy link
Member

phated commented Jun 19, 2016

Closed by #1692

@phated phated closed this Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants