Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Leverage endsWith instead of RegExp in matchers #82

Merged
merged 2 commits into from
Apr 7, 2022
Merged

feat: Leverage endsWith instead of RegExp in matchers #82

merged 2 commits into from
Apr 7, 2022

Conversation

phated
Copy link
Member

@phated phated commented Apr 7, 2022

This removes the RegExp matchers and instead replaces them with functions that use endsWith. We've mostly been trying to remove RegExp whenever possible because then people can stop flooding us with stupid ReDoS issues.

@phated phated requested a review from sttk April 7, 2022 02:23
@phated
Copy link
Member Author

phated commented Apr 7, 2022

Merging this.

@phated phated merged commit 6404724 into master Apr 7, 2022
@phated phated deleted the phated/remove-regexps branch April 7, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttk sttk Awaiting requested review from sttk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phated