Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for extension {module, register()} variant #74

Open
cspotcode opened this issue Jun 21, 2016 · 3 comments
Open

Add docs for extension {module, register()} variant #74

cspotcode opened this issue Jun 21, 2016 · 3 comments

Comments

@cspotcode
Copy link

It'd be cool if the documentation mentions this variant of extensions:

extensions: {
    ".foo" {
        module: "foo-loader", // load this module
        register: (fooLoader) { // pass it to this function
            fooLoader.register();
        }
    }
}

I see that it's already explained in js-interpret's readme so even linking there, but specifically in relation to the above syntax, would be helpful for newcomers.

@phated
Copy link
Member

phated commented Jun 21, 2016

Surfacing the docs from dependencies has been a big problem for us. All of it has to be done manually right now. If you'd like to send a PR, I'm willing to review it.

@cspotcode
Copy link
Author

I won't have time for a PR in the next few months; busy with work stuff.

On Tue, Jun 21, 2016 at 6:07 PM, Blaine Bublitz notifications@github.com
wrote:

Surfacing the docs from dependencies has been a big problem for us. All of
it has to be done manually right now. If you'd like to send a PR, I'm
willing to review it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#74 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAW-uNo8l4v0_FtUwyqCfabBT6cCsB0kks5qOGC_gaJpZM4I7Nxy
.

@phated
Copy link
Member

phated commented Jun 23, 2016

Same for all us maintainers. Feel free to submit a PR whenever you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants