Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tibdex/github-app-token from 1.3.0 to 1.6 #5

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/issue_tracker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
- name: Generate token
id: generate_token
uses: tibdex/github-app-token@36464acb844fc53b9b8b2401da68844f6b05ebb0
uses: tibdex/github-app-token@f717b5ecd4534d3c4df4ce9b5c1c2214f0f7cd06
with:
app_id: ${{ secrets.ISSUE_APP_ID }}
private_key: ${{ secrets.ISSUE_APP_PEM }}
Expand Down
2 changes: 1 addition & 1 deletion modules/gumgumBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ function buildRequests(validBidRequests, bidderRequest) {
data.pi = 5;
} else if (mediaTypes.video) {
data.pi = mediaTypes.video.linearity === 2 ? 6 : 7; // invideo : video
} else if (params.product && params.product.toLowerCase() === 'skin') {
} else if (params.product && params.product.toLowerCase() === 'skins') {
data.pi = 8;
}
} else { // legacy params
Expand Down
6 changes: 3 additions & 3 deletions modules/gumgumBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Maintainer: engineering@gumgum.com

GumGum adapter for Prebid.js
Please note that both video and in-video products require a mediaType of video.
In-screen, slot, and skin products should have a mediaType of banner.
In-screen, slot, and skins products should have a mediaType of banner.

# Test Parameters
```
Expand Down Expand Up @@ -51,7 +51,7 @@ var adUnits = [
}
]
},{
code: 'skin-placement',
code: 'skins-placement',
sizes: [[300, 50]],
mediaTypes: {
banner: {
Expand All @@ -63,7 +63,7 @@ var adUnits = [
bidder: 'gumgum',
params: {
zone: 'dc9d6be1', // GumGum Zone ID given to the client
product: 'skin',
product: 'skins',
bidfloor: 0.03 // CPM bid floor
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/gumgumBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,8 @@ describe('gumgumAdapter', function () {
const bidRequest = spec.buildRequests([request])[0];
expect(bidRequest.data.pi).to.equal(3);
});
it('should set the correct pi param if product param is found and is equal to skin', function () {
const request = { ...bidRequests[0], params: { ...zoneParam, product: 'Skin' } };
it('should set the correct pi param if product param is found and is equal to skins', function () {
const request = { ...bidRequests[0], params: { ...zoneParam, product: 'Skins' } };
const bidRequest = spec.buildRequests([request])[0];
expect(bidRequest.data.pi).to.equal(8);
});
Expand Down