-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: print deprecation reason correctly on ts 4.3+ #35
Conversation
98b24c1
to
2ae2d23
Compare
Thanks for taking a look @gund! Just rebased. I'll do a quick test locally to make sure this is still working as expected and comment back in a few. |
Thanks for quick rebase! All tests pass but there seems to be a single type error here
|
2ae2d23
to
f6d4b3d
Compare
f6d4b3d
to
e3c3c47
Compare
Code Climate has analyzed commit e3c3c47 and detected 0 issues on this pull request. View more on Code Climate. |
Thanks for the heads up. I missed that the rebase pulled in a new version of TypeScript and just had to update the backcompat for the other direction. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Thanks for the updates!
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for the review! Feel free to remove the backcompat code in the future if we want to drop support for TypeScript codebases before 4.3. 4.3 was released May 26th 2021, so I think waiting a year from now may be reasonable. |
This is an alternative to #33 that uses the builtin
ts.displayPartsToString
function and passes thecodeclimate
status check.I'd bias towards merging #33 if reviewers are on the fence. This PR was created before I realized that existed.