Add Custom form defined #125 #130

0xDkd · 2019-12-13T17:04:00Z

0xDkd · 2019-12-13T17:06:55Z

测试已经通过，不过我还是建议将 formMem 和 formFile 改成 from
另外如果可以 merge 我下次吧对应部分的 example 和 readme 也修改一下

感谢您的开源，我学到了很多知识！

codecov-io · 2019-12-13T17:10:30Z

Codecov Report

Merging #130 into master will increase coverage by 0.31%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage    92.8%   93.12%   +0.31%     
==========================================
  Files          32       32              
  Lines        1348     1396      +48     
==========================================
+ Hits         1251     1300      +49     
+ Misses         64       63       -1     
  Partials       33       33

Impacted Files	Coverage Δ
utils.go	`92% <ø> (ø)`	⬆️
core/core.go	`89.47% <ø> (ø)`	⬆️
encode/form.go	`89.05% <100%> (+5.53%)`	⬆️
encode/encode_core.go	`100% <100%> (ø)`	⬆️
bench/task.go	`87.8% <0%> (+1.21%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39593dc...24b85fc. Read the comment docs.

guonaihong · 2019-12-14T03:21:08Z

.gitignore

@@ -6,6 +6,7 @@
 *.dll
 *.so
 *.dylib
+.DS_Store


忽略Ds_Store用途是？

.gitignore

guonaihong · 2019-12-14T03:22:30Z

_example/go.mod

@@ -6,3 +6,5 @@ require (
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.1 // indirect
 )
+
+go 1.13


这里我建议不加go 1.13。

0xDkd · 2019-12-14T04:15:56Z

用Mac写代码系统会自动生成.Ds_Store

另外go13可能是编辑器自动格式化生成的。

我修改一下

guonaihong · 2019-12-14T06:09:07Z

encode/form_test.go

+				FileName    string
+				ContentType string
+				File        interface{}
+			}{FileName: "voice.pem", ContentType: "", File: "../testdata/voice.pcm"},


这里可以使用core.FileType结构体，代码会少写点。

Voice2: core.FormType{FileName: "voice.pem", ContentType: "", File: "../testdata/voice.pcm"}

guonaihong · 2019-12-14T06:11:23Z

encode/form_test.go

+				FileName    string
+				ContentType string
+				File        interface{}
+			}{FileName: "voice.pem", ContentType: "", File: "pcm1"},


也改成core.FormType

guonaihong · 2019-12-14T06:13:05Z

encode/form_test.go

+					FileName    string
+					ContentType string
+					File        interface{}
+				}{FileName: "voice.pem", ContentType: "", File: core.FormMem("pcm1")},


改成core.FormType

guonaihong · 2019-12-14T06:13:32Z

encode/form_test.go

+					FileName    string
+					ContentType string
+					File        interface{}
+				}{FileName: "voice.pem", ContentType: "", File: "pcm1"},


改成FormType

guonaihong · 2019-12-14T06:13:50Z

encode/form_test.go

+					FileName    string
+					ContentType string
+					File        interface{}
+				}{FileName: "voice.pem", ContentType: "", File: "../testdata/voice.pcm"},


改成FormType

guonaihong · 2019-12-14T06:16:20Z

encode/form_test.go

+					File        interface{}
+				}{FileName: "voice.pem", ContentType: "", File: "../testdata/voice.pcm"},
+			},
+		},


测试正确的情况可以把结构体内嵌的case加上。比如把FormType内嵌到一个业务结构体里面。

这个没有明白是什么意思，能麻烦您举个例子吗😂

把下面的结构体用起来，看能否处理结构体内嵌的情况。

type test_Form_2_struct struct { Mode string `form:"mode"` Text string `form:"text"` core.FormType `form:"voice" form-mem:"true"` //内嵌core.FormType Url string `form:"url"` }

Dataflow (guonaihong#133)

guonaihong · 2019-12-14T11:29:13Z

代码测试覆盖度有点下降，可以使用下面两条命令观查并提升。

make test
go tool cover -html=coverage.out

0xDkd · 2019-12-14T14:51:19Z

感谢指导，终于合格了😭

另外请您推荐一点学习 Go 的资料可以吗，我感觉您的代码让我学到了很多

guonaihong · 2019-12-15T02:42:28Z

go的话，就 go程序设计语言

guonaihong · 2019-12-15T02:43:05Z

encode/form.go

@@ -28,7 +31,7 @@ func toBytes(val reflect.Value) (all []byte, err error) {
 	case []byte:
 		all = v
 	default:
-
+		fmt.Println(val.Kind())


这句打印的目的是？

guonaihong · 2019-12-15T02:51:26Z

最后在测试case 加下结构体内嵌的情况，这个pr基本就可以。

type test_Form_2_struct struct {
	Mode   string        `form:"mode"`
	Text   string        `form:"text"`
	core.FormType `form:"voice" form-mem:"true"` //内嵌core.FormType
	Url string `form:"url"`
}

retry-backoff (guonaihong#134)

0xDkd · 2019-12-15T14:01:59Z

已经加上了，另外如果有什么任务也可以分给我

guonaihong · 2019-12-15T14:32:29Z

下一个可以玩下。#128。pr明天早上我再过下，没问题就合并

guonaihong · 2019-12-15T14:36:21Z

encode/form.go

+				if !okToo {
+					return fmt.Errorf("unknown type formFileWrite:%T, openFile:%t", v, openFile)
+				}
+				content = []byte(s)


这里可以使用core. StringToBytes转换。
在go里面[]byte(s)会分配内存。

encode/form.go

guonaihong · 2019-12-16T01:18:16Z

encode/encode_core.go

@@ -156,6 +156,13 @@ func encode(val reflect.Value, sf reflect.StructField, a Adder) error {

 		typ := val.Type()

+		if strings.HasSuffix(typ.Name(), "FormType") {
+			if err := parseTagAndSet(val, sf, a); err != nil {


这里可以用　return parseTagAndSet(val, sf, a)替换

Add Custom form defined guonaihong#125

b6e87e4

guonaihong reviewed Dec 14, 2019

View reviewed changes

.gitignore

@@ -6,6 +6,7 @@

*.dll

*.so

*.dylib

.DS_Store

Copy link

Owner

guonaihong Dec 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

忽略Ds_Store用途是？

.gitignore Show resolved Hide resolved

guonaihong reviewed Dec 14, 2019

View reviewed changes

0xDkd pushed a commit to 0xDkd/gout that referenced this pull request Dec 14, 2019

reduce some redundant code guonaihong#130

4d7a52f

0xDkd force-pushed the master branch from 5dca906 to b6e87e4 Compare December 14, 2019 10:21

aimerforreimu added 5 commits December 14, 2019 18:26

remove idea

87ec4af

remove go version in go mod

c229ef5

Merge pull request #1 from guonaihong/master

bb99a06

Dataflow (guonaihong#133)

sync from master repo

a5360c0

sync

39a8dd2

improve code coverage

65d878d

guonaihong reviewed Dec 15, 2019

View reviewed changes

aimerforreimu added 2 commits December 15, 2019 21:50

Merge pull request #2 from guonaihong/master

ece2e95

retry-backoff (guonaihong#134)

add inner struct test

1885950

guonaihong reviewed Dec 15, 2019

View reviewed changes

[]byte -> core.StringToBytes

f583eb5

guonaihong reviewed Dec 16, 2019

View reviewed changes

guonaihong changed the title ~~Add Custom form defined https://github.com/guonaihong/gout/issues/125~~ Add Custom form defined #125 Dec 16, 2019

reduce code

24b85fc

guonaihong merged commit 3291333 into guonaihong:master Dec 16, 2019

guonaihong mentioned this pull request Dec 16, 2019

v0.0.5版本计划 #121

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Custom form defined #125 #130

Add Custom form defined #125 #130

0xDkd commented Dec 13, 2019 •

edited by guonaihong

Loading

0xDkd commented Dec 13, 2019

codecov-io commented Dec 13, 2019 •

edited

Loading

guonaihong Dec 14, 2019

guonaihong Dec 14, 2019

0xDkd commented Dec 14, 2019 •

edited

Loading

guonaihong Dec 14, 2019 •

edited

Loading

guonaihong Dec 14, 2019

guonaihong Dec 14, 2019

guonaihong Dec 14, 2019

guonaihong Dec 14, 2019

guonaihong Dec 14, 2019

0xDkd Dec 14, 2019

guonaihong Dec 14, 2019

guonaihong commented Dec 14, 2019

0xDkd commented Dec 14, 2019

guonaihong commented Dec 15, 2019

guonaihong Dec 15, 2019

guonaihong commented Dec 15, 2019 •

edited

Loading

0xDkd commented Dec 15, 2019

guonaihong commented Dec 15, 2019 •

edited

Loading

guonaihong Dec 15, 2019

guonaihong Dec 16, 2019

Add Custom form defined #125 #130

Add Custom form defined #125 #130

Conversation

0xDkd commented Dec 13, 2019 • edited by guonaihong Loading

0xDkd commented Dec 13, 2019

codecov-io commented Dec 13, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xDkd commented Dec 14, 2019 • edited Loading

guonaihong Dec 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guonaihong commented Dec 14, 2019

0xDkd commented Dec 14, 2019

guonaihong commented Dec 15, 2019

Choose a reason for hiding this comment

guonaihong commented Dec 15, 2019 • edited Loading

0xDkd commented Dec 15, 2019

guonaihong commented Dec 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xDkd commented Dec 13, 2019 •

edited by guonaihong

Loading

codecov-io commented Dec 13, 2019 •

edited

Loading

0xDkd commented Dec 14, 2019 •

edited

Loading

guonaihong Dec 14, 2019 •

edited

Loading

guonaihong commented Dec 15, 2019 •

edited

Loading

guonaihong commented Dec 15, 2019 •

edited

Loading