Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the issue that sometimes it is hard to move crop box #243

Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix: fix the issue that sometimes it is hard to move crop box #243

merged 1 commit into from
Jan 16, 2023

Conversation

guoyingtao
Copy link
Owner

No description provided.

@guoyingtao guoyingtao marked this pull request as ready for review January 15, 2023 13:05
@guoyingtao guoyingtao requested a review from vanniktech January 15, 2023 13:05
@guoyingtao guoyingtao mentioned this pull request Jan 15, 2023
Closed
vanniktech
vanniktech approved these changes Jan 15, 2023
View reviewed changes
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is non trivial for me to test as I don't have a device and I'd need to build a new release version which would then needed to be tested.

Code changes look good. Feel free to merge

@guoyingtao guoyingtao merged commit af51496 into master Jan 16, 2023
@guoyingtao guoyingtao deleted the fix-update-cropbox branch January 28, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoyingtao @vanniktech