Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::CompositeIO and ::Parts deprecation warning #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

konami99
Copy link

@konami99 konami99 commented May 3, 2023

I'm using fitgem_oauth2 (3.0.0) and it depends on faraday (1.0.1), which depends on multipart-post (2.3.0).

multipart-post 2.3.0 is emitting this warning

Top level ::CompositeIO is deprecated, require 'multipart/post' and use `Multipart::Post::CompositeReadIO` instead!
Top level ::Parts is deprecated, require 'multipart/post' and use `Multipart::Post::Parts` instead!

The warning is related to how faraday uses multipart-post (lib/faraday/file_part.rb)

...
# @return [IO]
FilePart = ::UploadIO

# Multipart value used to POST a file.
#
# @deprecated Use FilePart instead of this class. It behaves identically, with
#   a matching name to ParamPart.
UploadIO = ::UploadIO
...

Starting from faraday 1.9.0, the team has removed this part and opted-in for another library faraday-multipart (see change log lostisland/faraday@v1.8.0...v1.9.0) and therefore has fixed the warning. So I'm bumping faraday to 1.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant