Added python 3.8 support #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being resolved: #187
Solution description
Python 3.8 uses an older but still supported scheme for type hinting. This updates type hints to work with python 3.8
Changes
All incompatible type hints were changes to work in python 3.8.
str.removeprefix was introduced in python 3.9, so a backports module was created that contained that functionality.
Potential impacts
It's possible I didn't test all paths, so python 3.8 could still be broken in some edge cases.
Steps to test
Running
python3 -m pytest -c ./tests/pytest.ini -W ignore::pytest.PytestCollectionWarning --alluredir=./allure-resultsin both python 3.8 and python 3.10 resulted in no failures.PR Tasks