Symbols as keys #272
Merged
Symbols as keys #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayc0
commented
Aug 8, 2024
Comment on lines
+13
to
+15
| } else { | ||
| throw new Error('Expected obj to match the foo pattern!'); | ||
| } |
There was a problem hiding this comment.
This test only wasn't enough as it was passing before (as it was stripping all symbols)
So I added the other if for the negative check
|
Awesome, thank you! |
gvergnaud
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
isMatchingwasn't working with symbols:But the exact same code works with strings:
So I updated the
matchPatternfunction to also iterate through symbols in addition to keys (Object.keys()skips symbols, but we can useObject.getOwnPropertySymbols()for those)I also added a test that is failing without my changes, but passes after: