Fix bugs and enable Custom Auth Check #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was trying to access res.toUser when res was undefined, causing an exception. Now error callback is on its own logic branch.
The default auth check is same as before but it can now be overridden by the user. The method gets (fromUser, toUser) args - although toUser is not used by the default auth check it could be in specific apps. Also note: the auth check now runs *every time* impersonate is called, not only the first time like before, because the permissions might depend on toUser.
This method is handy if you're not using Blaze (otherwise you can use template helpers)
|
This is great! Thank you Data Meister! |
|
You're welcome! |
|
I added a couple more commits. Would you be happy to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.