Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency cmdk to v1 #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency cmdk to v1 #156

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 8, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cmdk (source) ^0.2.0 -> ^1.0.0 age adoption passing confidence

Release Notes

pacocoursey/cmdk (cmdk)

v1.0.4

Compare Source

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v1.0.3...v1.0.4

v1.0.3

Compare Source

  • Fix use-sync-external-store shim for compatibility with Next.js 15 and React 19 RC

v1.0.2

Compare Source

  • Remove use-sync-external-store shim to support Next.js 15 and React 19 RC

Full Changelog: pacocoursey/cmdk@v1.0.1...v1.0.2

v1.0.1

Compare Source

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v1.0.0...v1.0.1

v1.0.0

Compare Source

This is a major version release as it contains breaking changes.

Breaking Changes

You will need to update your code to account for these changes before upgrading to cmdk@1.0.0.

value is now case sensitive 3dae25d

The value prop you pass to Command.Item and receive in onSelect is now case sensitive. But while the value is no longer lowercased, it is still trimmed.

Command.List is now required (CommandList in shadcn) 54aa261

Rendering the Command.List part (CommandList if using shadcn) is now mandatory. Otherwise, you should expect to see an error like this:

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))

The fix:

// Before
<Command label="Command Menu">
	<Command.Input />
	<Command.Item />
	{/* ... */}
</Command>
// After
<Command label="Command Menu">
	<Command.Input />

	<Command.List>
		<Command.Item />
		{/* ... */}
	</Command.List>
</Command>
Update [aria-disabled] and [aria-selected] CSS selectors c57e6b7

The aria-disabled and aria-selected props will now be set to false, instead of being undefined. If you previously used CSS selectors based on attribute presence, you will now need to use the attribute value.

/* Before */
[aria-disabled] {}
:not([aria-disabled]) {}

/* After */
[aria-disabled="true"] {}
[aria-disabled="false"] {}

What's Changed

New Contributors

Full Changelog: pacocoursey/cmdk@v0.2.1...v1.0.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
full-stack-skeleton ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 8:34pm

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.70%. Comparing base (5f39f75) to head (08184b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   38.79%   37.70%   -1.10%     
==========================================
  Files          25       25              
  Lines         647      809     +162     
==========================================
+ Hits          251      305      +54     
- Misses        351      459     +108     
  Partials       45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 52f7a01 to 6788b90 Compare March 22, 2024 13:14
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 6788b90 to 463fd4c Compare March 25, 2024 23:01
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 463fd4c to 61d5cad Compare April 3, 2024 19:30
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 61d5cad to 1c90af3 Compare April 15, 2024 21:45
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 1c90af3 to d4a63e2 Compare April 22, 2024 18:23
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from d4a63e2 to 61491f7 Compare April 30, 2024 18:59
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 61491f7 to 1557793 Compare May 6, 2024 15:18
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 1557793 to 6bed6f3 Compare May 17, 2024 20:43
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 6bed6f3 to 885460b Compare June 4, 2024 19:10
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 885460b to d6e20a0 Compare June 10, 2024 20:12
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from d6e20a0 to 6dfcf98 Compare June 20, 2024 17:37
@renovate renovate bot force-pushed the renovate/cmdk-1.x branch from 6dfcf98 to 6d66d80 Compare June 27, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants