fix css loader regression #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gwleuverink
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
============================================
- Coverage 97.58% 97.47% -0.12%
- Complexity 57 59 +2
============================================
Files 8 8
Lines 290 277 -13
============================================
- Hits 283 270 -13
Misses 7 7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression that caused css imports to error.
This was caused because we're compiling js code in the module boilerplate that was meant to auto invoke a iife export.
I've extracted the boilerplate to a blade file for finer templating control compared to the heredoc string used before.
caveats
Using a blade.js extension we kept js syntax highlighting, but vscode autoformat mucks up the syntax on save. Also blade directives caused squigglies everywhere.
I've settled for a blade.php file for now. This causes us to lose all js syntax highlighting. But no more squigglies or formatting issues. I'm exploring a better approach.
Also, the blade file is not picked up by code coverage. I have to fix that and add a regression test for the initial failing import.