Add gwt 2.11 sdk feature #487
Conversation
There was a problem hiding this comment.
I briefly looked at past SDKs, and this seems to be consistent with them, but I'm not sure that this makes them right either...
Also did we miss GWT 2.10?
I approved because I don't know enough about this to say that we're wrong, but just wanted to check these things in case they mattered.
| licenseURL = https://github.com/gwt-plugins/gwt-eclipse-plugin/blob/master/LICENSE.md | ||
|
|
||
| # "license" property - text of the "Feature Update License" | ||
| # should be plain text version of license agreement pointed to be "licenseURL" | ||
| license=\ |
There was a problem hiding this comment.
Shouldnt the URL, license be of the contents of GWT? If the user is asking to download GWT, shouldn't we be letting them know the license of it?
| </license> | ||
|
|
||
| <url> | ||
| <update label="GWT Eclipse Plugin Update Site" url="http://storage.googleapis.com/gwt-eclipse-plugin/v3/release"/> |
There was a problem hiding this comment.
This URL hasn't been correct in a while, I think we want to point to something like https://plugins.gwtproject.org/eclipse/gwt-eclipse-plugin/4.0.0/ instead?
Adding GWT 2.10 is definitely possible. GWT plugin
|
|
https://www.gwtproject.org/terms.html lists the license file, apache v2... We don't have a top-level file in the git repo (but we should) that shows the license. Here's the file that makes its way into the download zip: https://github.com/gwtproject/gwt/blob/main/distro-source/core/src/COPYING to version that link, you could use https://github.com/gwtproject/gwt/blob/2.11.0/distro-source/core/src/COPYING (with the version instead of the branch). -- Removing old versions is fine by me, 2.7 at least should probably be removed since I don't think it will run on the min Java version for eclipse any more (and possibly 2.8 too). Maybe in a follow-up PR? I don't have strong opinions about how we should provide downloads, I'd vote that we don't worry about it too much for this release. |
protoism
force-pushed
the
feature/remove_apiclientlib
branch
from
b000046
to
3e95247
Compare
protoism
force-pushed
the
feature/add-gwt-2.11-sdk
branch
from
032c2fe
to
d3c18f7
Compare
GWT 2.11 at last.