Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes sidekiq deprecation #46

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

Ross-Hunter
Copy link
Contributor

Latest sidekiq produces deprecation warnings with this gem. Simply removed .options from the calls in config.rb results in no deprecations, all tests pass, and the code seems to work. Interested to see how this fares on Travis testing with older Sidekiq versions.

2022-08-08T15:49:59.336Z pid=8664 tid=1ef0 INFO: Booting Sidekiq 6.5.3 with Sidekiq::RedisConnection::RedisAdapter options {}
2022-08-08T15:49:59.359Z pid=8664 tid=1ef0 WARN: `config.options[:key] = value` is deprecated, use `config[:key] = value`: ["/Users/vox/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/gems/sidekiq-grouping-1.1.0/lib/sidekiq/grouping/config.rb:5:in `options'", "/Users/vox/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/gems/sidekiq-grouping-1.1.0/lib/sidekiq/grouping/config.rb:10:in `block in <module:Config>'"]
2022-08-08T15:49:59.360Z pid=8664 tid=1ef0 WARN: `config.options[:key] = value` is deprecated, use `config[:key] = value`: ["/Users/vox/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/gems/sidekiq-grouping-1.1.0/lib/sidekiq/grouping/config.rb:5:in `options'", "/Users/vox/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/gems/sidekiq-grouping-1.1.0/lib/sidekiq/grouping/config.rb:15:in `block in <module:Config>'"]
2022-08-08T15:49:59.360Z pid=8664 tid=1ef0 WARN: `config.options[:key] = value` is deprecated, use `config[:key] = value`: ["/Users/vox/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/gems/sidekiq-grouping-1.1.0/lib/sidekiq/grouping/config.rb:5:in `options'", "/Users/vox/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/gems/sidekiq-grouping-1.1.0/lib/sidekiq/grouping/config.rb:20:in `block in <module:Config>'"]
2022-08-08T15:49:59.360Z pid=8664 tid=1ef0 WARN: `config.options[:key] = value` is deprecated, use `config[:key] = value`: ["/Users/vox/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/gems/sidekiq-grouping-1.1.0/lib/sidekiq/grouping/config.rb:5:in `options'", "/Users/vox/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/gems/sidekiq-grouping-1.1.0/lib/sidekiq/grouping/config.rb:25:in `block in <module:Config>'"]
2022-08-08T15:49:59.360Z pid=8664 tid=1ef0 INFO: [Sidekiq::Grouping] Started polling batches every 5 seconds

@matoni109
Copy link

matoni109 commented Oct 24, 2022

would be great to get some discussion around this @gzigzigzeo if this will pass cli

@gzigzigzeo
Copy link
Owner

Thank you!

@gzigzigzeo gzigzigzeo merged commit d4f6c4c into gzigzigzeo:master Nov 29, 2022
@Ross-Hunter Ross-Hunter deleted the fix/options-deprecation branch November 29, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants