improve search, and remove tiny blue arcs #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for convenience, I ported the changes to the teal theme |
|
Hello @saegl5, |
|
@h16nning glad I could help :) |
|
related: typora/typora-issues#5555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @h16nning, I enjoy your theme, it's very clean and legible
sometimes, though, I have a little trouble distinguishing which text search is selected from those matched, or which searched item is active in the sidebar...
example 1: (editor)
example 2: (sidebar)
the pull request also contains some quality of life additions...
example 3: (code block)
example 4: (blockquote)
regarding example 2, I did consider making the active searched item bold, however to me using a different background color instead felt clearer.
anyway, i hope these additions prove useful
enjoy