Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unnecessary deps to extras. #9

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

J08nY
Copy link

@J08nY J08nY commented Jul 24, 2023

This PR moves the dephell dependency to "dev" requires as it is not needed to use the library.
Similarly, pytest dependencies are moved to a new "test" extra as they are not needed to use the library and
are polluting dependencies unnecessarily.

This is a significant usability improvement as dephell is deprecated and unmaintained and also its installation in a current modern Python venv fails due to issues in outdated dependencies (m2r package, same error as jupyter/notebook#6531).

@J08nY
Copy link
Author

J08nY commented Jul 24, 2023

Hey @rben-dev, @PThierry, @h2lab,
there are three outstanding PRs that I believe are ready to be merged that improve the user experience of the library and fix concrete issues. It would mean a lot if you could find the time to merge them and get a release out. I am using LEIA in a downstream project of mine and ran into these issues (#6, #8, #9). Thanks!

@rben-dev
Copy link

rben-dev commented Jul 24, 2023

Hi @J08nY,

Sorry for the late answer, but we did not get the notifications for the issues and these PRs!
We will review and merge them asap :-) (and by the way thanks a lot for your fixes and work on LEIA!)

Regards,

@rben-dev rben-dev merged commit 8cd389d into h2lab:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants