Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliable test_post_with_headers #94

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

wimglenn
Copy link
Contributor

@wimglenn wimglenn commented Nov 9, 2023

This will make the test fail if the mock hasn't matched (in the original PR it failed for other reason, earlier, not because of a mock mismatch).

By using https://httpbin.org/foo instead of https://example.com, the resp.status will be 404 instead of 200 if the mock didn't apply successfully. That's a less confusing failure mode.

@sarayourfriend
Copy link
Collaborator

Thanks @wimglenn 🚀

@sarayourfriend sarayourfriend merged commit a06f325 into h2non:master Nov 9, 2023
8 checks passed
@wimglenn wimglenn deleted the test-post-with-headers branch November 9, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants