fix(regex): Fix usage of regex values in header matchers #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nexpectedly has None value
sarayourfriend
force-pushed
the
fix/re-pattern-headers
branch
from
37e1de6 to
adacdba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96.
Adds new unit tests to reproduce the issue in the first commit, then fixes them in the subsequent commit. I also added more tests to cover other aspects of the headers matcher that were not tested before and fixed an issue I found with using
"re/.../"formatted strings and actual compiled regex patterns as values in the headers.In a future PR I'd like to add tests for each matcher type.