Change required version of xlrd package #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
oleksiyskononenko
approved these changes
Feb 11, 2021
|
Building from scratch looks more desirable to get more speed. But yes, it will take up some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the required version of
xlrdpackage to "<=1.2.0", due to the fact that the latest version 2.0.0 removed support for xlsx files. Note that we are only changing the "extra" requirements: these are not forced on the user, rather they are what our package recommends to have.It might be desirable at this point to either switch to
openpyxllibrary for reading xlsx files, or to implement the necessary logic from scratch -- but both of these options require considerable time.This change, on the other hand, can be done quickly, and it solves the immediate problem that some of our tests that use xlsx files are now failing.
Closes #2823