Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUBDEV-8266 XGBoost alias rewriting #5641

Merged
merged 7 commits into from
Aug 31, 2021

Conversation

maurever
Copy link
Contributor

@maurever maurever self-assigned this Aug 24, 2021
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this ticket! 🍺 I have a couple of suggestion that won't affect the supposed behavior. Also one test failed.

Copy link
Contributor

@michalkurka michalkurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maurever maurever merged commit b200e1e into master Aug 31, 2021
@maurever maurever deleted the maurever_PUBDEV-8266_xgboost_col_sample_rate branch August 31, 2021 11:12
maurever added a commit that referenced this pull request Oct 5, 2021
PUBDEV-8266 fix alias rewriting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants