Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build on CUDA 10.1: #768

Merged
merged 2 commits into from
May 28, 2019
Merged

fix build on CUDA 10.1: #768

merged 2 commits into from
May 28, 2019

Conversation

sh1ng
Copy link
Contributor

@sh1ng sh1ng commented May 24, 2019 •
edited
Loading

  • use __shfl_down_sync
  • add kmeans copy overload methods for device_allocator
  • linking with libcublasLt_static.a

Besides the fact that we're not going to support CUDA-10.1 for now(see dmlc/xgboost#4264). It's better to be compatible with it.

@sh1ng
fix build on CUDA 10.1:
64548ae 
* use __shfl_down_sync
* add kmeans copy overload methods for device_allocator
@sh1ng
Copy link
Contributor Author

sh1ng commented May 24, 2019

It's not linking on CUDA-10.1 because NVidia made extra changes on libcublas.
https://devtalk.nvidia.com/default/topic/1048658/gpu-accelerated-libraries/linker-problem-with-cuda-10-1-105-on-cento-7-undefined-references/
tensorflow/tensorflow#26150

@sh1ng sh1ng requested a review from pseudotensor May 27, 2019 09:34
pseudotensor
pseudotensor approved these changes May 28, 2019
View reviewed changes
Copy link
Collaborator

@pseudotensor pseudotensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Let's see :)

@sh1ng sh1ng merged commit 2c14cdd into master May 28, 2019
@sh1ng sh1ng deleted the fix_764 branch May 28, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudotensor pseudotensor pseudotensor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh1ng @pseudotensor