Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update dependency electron-serve to v2" #4947

Merged
merged 1 commit into from
May 27, 2024

Conversation

h3poteto
Copy link
Owner

Reverts #4937

A JavaScript error occurred in the main process
Uncaught Exception:
Error [ERR_REQUIRE_ESM]: require() of ES Module /run/media/h3poteto/ssd1/dev/src/github.com/h3poteto/whalebird-desktop/node_modules/electron-serve/index.js from /run/media/h3poteto/ssd1/dev/src/github.com/h3poteto/whalebird-desktop/app/background.js not supported.
Instead change the require of index.js in /run/media/h3poteto/ssd1/dev/src/github.com/h3poteto/whalebird-desktop/app/background.js to a dynamic import() which is available in all CommonJS modules.
    at c._load (node:electron/js2c/node_init:2:13672)
    at webpackUniversalModuleDefinition (/run/media/h3poteto/ssd1/dev/src/github.com/h3poteto/whalebird-desktop/app/background.js:3:28)
    at Object.<anonymous> (/run/media/h3poteto/ssd1/dev/src/github.com/h3poteto/whalebird-desktop/app/background.js:10:3)
    at c._load (node:electron/js2c/node_init:2:13672)

@h3poteto h3poteto merged commit 6e725c2 into main May 27, 2024
2 checks passed
@h3poteto h3poteto deleted the revert-4937-renovate/electron-serve-2.x branch May 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant