Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change style.css to main.css #1116

Closed
corydorning opened this issue Jun 6, 2012 · 13 comments
Closed

Change style.css to main.css #1116

corydorning opened this issue Jun 6, 2012 · 13 comments
Labels

Comments

@corydorning
Copy link

Does it make sense to go ahead and change style.css to main.css to provide some consistency with the recent change of script.js to main.js.

I realize there was more to it than just the name 'script.js' (RequireJS) and that there's only one CSS file, but it seems, dare I say, more 'semantic'.

@davidmurdoch
Copy link

I personally split style.css into common.css (css normalization), main.css (for author stuff), and helpers.css (.visuallyHidden, .clearfix etc). I don't like having to scroll all over the place to find my "author" styles.

I always thought style was redundant ... its a Style Sheet; we already know that it contains styles.
Anyway, I'm +1 on the name change (and for splitting them into 3 parts to be concatenated by the build script, of course).

@corydorning
Copy link
Author

agreed. for me its a base.css (which includes normalization and helpers) and main.css for site specific styling.

@necolas
Copy link
Member

necolas commented Jun 6, 2012

I quite like this idea too, even if it's just for project consistency.

@chenzihui
Copy link

+1 on name change for consistency with main.js

@Gavrisimo
Copy link

+1

@jonrundle
Copy link

+1 for main.css

@grayghostvisuals
Copy link

+1 for consistency and main.css

@jacobbednarz
Copy link

For large projects I would agree with @davidmurdoch however for this project, I think consistency is more important. +1 for the name change to main.css

@necolas
Copy link
Member

necolas commented Jun 9, 2012

For large projects, you should really be using more than 3 CSS files anyway :)

@necolas necolas closed this as completed in 7aa306c Jun 9, 2012
@Gavrisimo
Copy link

For large projects you should really be using css preprocessors... ;D

@jacobbednarz
Copy link

That's opening a whole new argument there @Gavrisimo :p

falbertin pushed a commit to falbertin/html5-boilerplate that referenced this issue Jun 20, 2012
@wamatt
Copy link

wamatt commented Jul 24, 2012

I'm with @corydorning @davidmurdoch on the the idea of seperating the normalization and helpers out from the site specific code.

@drublic
Copy link
Member

drublic commented Jul 24, 2012

Please have a look at PR #1140. There you can see an approach to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants