Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miketaylr's feedback #2

Closed
paulirish opened this issue Jan 24, 2010 · 1 comment
Closed

miketaylr's feedback #2

paulirish opened this issue Jan 24, 2010 · 1 comment

Comments

@paulirish
Copy link
Member

Notes on Paul Irish's starter template.

Mike Taylor
11/08/2009

  • meta name=keywords? I'm no SEO wizard, but I tend to still use this guy in conjunction with meta name=description.
  • using HTML5 doctype and a html5 shiv script for IE, yet <div id=header>, <div id=footer>.
    Why not <header> & <footer>? Although I can understand if you don't want to force people to go server-side to fix FF2.
  • How is<html lang=en> different from <meta http-equiv="content-language" content="en">? There might be something I'm not aware of here.
  • In html5, <script type> defaults to text/javascript if not present. So, you can leave it out if you want to live in the future. I don't know if there are any real-world consequences to doing so today.

http://www.whatwg.org/specs/web-apps/current-work/#script
'(The default, which is used if the attribute is absent, is "text/javascript".)'

  • Remy's html5 enabling script is a little out of date--<dialog> is no longer in the spec, nor is <eventsource>. (There are naturally more new elements in the spec, but I can't imagine you'd try to style a element, for example.)
  • In script.js small typo:

//common domready code => common domready code

  • In script.js FOO.config and FOO.strings could use some simple explanatory comments to explain why they're in there.
  • In reset.css:
    • dialog can be removed from lines 21 and 36.
    • Line 32 of the html5 reset stylesheet (body{line-height:1} is essentially getting overwritten by line 109 (yui's body * {line-height:1.22em}, right? Or would there be some meaningful reason to have body at 1 but all of body's descendants at 1.22em? If not, 32 could be removed.
    • Shouldn't line 121 also include .ie6? i.e., .ie6 img, .ie7 img {-ms-interpol...;}
    • A few missing ending semi-colons: line 129, 140, 151, 152
    • If you were crazy like i am, you could change line 144 -> color: #003366 -> color: html5boilerplate.com paragraph issue on mobile safari #36.
@paulirish
Copy link
Member Author

index.html cleanup. addresses miketaylr's old concerns. closed by 1988165

@johnfoliot johnfoliot mentioned this issue Nov 30, 2011
Closed
chrispsn added a commit to chrispsn/html5-boilerplate that referenced this issue Apr 8, 2012
@chrispsn
Attempt h5bp#2 at preserving my changes to index.html
b41dbbe
falbertin pushed a commit to sengeezer/html5-boilerplate that referenced this issue Feb 12, 2013
@roblarsen
Merge pull request h5bp#131 from ziggys/feature-relative-paths
5a361b2 
Relative paths for images/fonts. Fixes h5bp#2
@ghost ghost mentioned this issue Mar 12, 2013
Closed
@tchalvak tchalvak mentioned this issue Apr 10, 2013
Closed
@jitendravyas jitendravyas mentioned this issue Aug 7, 2013
Closed
@QWp6t QWp6t mentioned this issue Apr 25, 2014
Closed
@benburkhart1 benburkhart1 mentioned this issue May 28, 2014
Closed
roblarsen added a commit that referenced this issue Mar 13, 2023
@roblarsen
merge conflict #2
8bf7014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulirish