Fixed the console stubbing utility.
#1229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mathiasbynens Got any time to look over what needs doing with this function? |
|
legit. 👍 |
drublic
pushed a commit
that referenced
this pull request
Oct 14, 2012
Expose `console` object to global scope in IE6 and IE7 Reference: gh-1229
|
Thanks for the PR, @bmcustodio. I've added this PR and the other improvements outlined in the comments in 578f377 on branch |
|
@drublic: Yep, the code in this branch works just fine under IE6 and IE7. I have ran your test as well and everything seems smooth. |
|
Thanks for looking into that again, @bmcustodio! |
|
Thanks guys. Merged into master now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is being discussed in http://git.io/qEe7WA, the
consolestubbing utility is not working as intended (it is throwing, for example, in IE6). The associated commit, which is essentially a shortened version of the patch provided by @bgrins in the diff discussion, fixes this problem by actually exposing a globalconsoleobject (which will either be the originalconsolemethod, if defined, or a dummy{}object).