Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google Frame #1380

Closed
wants to merge 3 commits into from
Closed

Remove Google Frame #1380

wants to merge 3 commits into from

Conversation

qgustavor
Copy link

As said at http://blog.chromium.org/2013/06/retiring-chrome-frame.html Google Frame was retired/obsolete. The googleframe class was changed, and the message, removed.

@necolas
Copy link
Member

necolas commented Jun 13, 2013

Please can you squash these commits and then force push to your branch. Thanks

@qgustavor
Copy link
Author

I have seen that, but as I'm new to github, how I can do that?

Edit: I tried to do that you said: there's the commit dde33ff

@mikealmond
Copy link
Contributor

I like the idea of keeping the browse happy callout, instead of removing it all together.

If this is going to be merged in, I'd like to see the conditional comment include IE7 and 8. <!--[if lt IE 9]>. Thoughts?

@FagnerMartinsBrack
Copy link
Contributor

@mikealmond
edit: I read too fast sorry.

Agree it should comply to IE 7 too (I thought it was already O.O).
IE 8 is still widely used, so we should still support it.

@mikealmond
Copy link
Contributor

@FagnerMartinsBrack That statement is saying anything under IE9 (IE 6, 7, 8). This would not include IE9.

It could also be written as <!--[if lte IE 8]>

Check out http://msdn.microsoft.com/en-us/library/ms537512(v=vs.85).aspx for more information on IE conditional statements

@FagnerMartinsBrack
Copy link
Contributor

@mikealmond
Ok, I got it.

My point is:
The message is annoying. It would appear to a huge portion of users if implemented for the IE8 version. IE 6 is dead and IE 7 should not be relevant anymore. IE 8 is still widely used though, so we should not annoy users with that message, but support IE 8 without a default message.

Perhaps in the near future add IE8 to the party, but I think it is too soon for that.

@necolas
Copy link
Member

necolas commented Jun 14, 2013

Not going to change the browsers it's aimed at. We'll remove it entirely for v5.0.0 when we drop IE 6/7 support.

@AliMD
Copy link

AliMD commented Jun 15, 2013

We need google frame for old user and please don`t remove it

@alrra
Copy link
Member

alrra commented Jun 15, 2013

We need google frame for old user and please don`t remove it

@AliMD it will still be available in H5BP versions < 5, see: #1050.

@necolas
Copy link
Member

necolas commented Jun 24, 2013

@qgustavor Please can you force push (git push -f origin patch-1) the squash commit to your patch branch so that the PR is updated with the correct commit? Thanks

@paulirish
Copy link
Member

Manually squashed and pushed this guy. 02713ee

Thanks @qgustavor !!

@paulirish paulirish closed this Jun 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants