-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Google Frame #1380
Remove Google Frame #1380
Conversation
As said at http://blog.chromium.org/2013/06/retiring-chrome-frame.html Google Frame was retired/obsolete. The `class="chromeframe"` still needs to updated.
Please can you squash these commits and then force push to your branch. Thanks |
I have seen that, but as I'm new to github, how I can do that? Edit: I tried to do that you said: there's the commit dde33ff |
I like the idea of keeping the browse happy callout, instead of removing it all together. If this is going to be merged in, I'd like to see the conditional comment include IE7 and 8. |
@mikealmond Agree it should comply to IE 7 too (I thought it was already O.O). |
@FagnerMartinsBrack That statement is saying anything under IE9 (IE 6, 7, 8). This would not include IE9. It could also be written as Check out http://msdn.microsoft.com/en-us/library/ms537512(v=vs.85).aspx for more information on IE conditional statements |
@mikealmond My point is: Perhaps in the near future add IE8 to the party, but I think it is too soon for that. |
Not going to change the browsers it's aimed at. We'll remove it entirely for v5.0.0 when we drop IE 6/7 support. |
We need google frame for old user and please don`t remove it |
@qgustavor Please can you force push ( |
Manually squashed and pushed this guy. 02713ee Thanks @qgustavor !! |
As said at http://blog.chromium.org/2013/06/retiring-chrome-frame.html Google Frame was retired/obsolete. The
googleframe
class was changed, and the message, removed.