Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalised the DOCTYPE to meet standard syntax and fix highlighting err... #1543

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2014

...ors in some IDEs and HTML Editors

Simple but important for a template. Easy fix. Apologies if I've done the pull request incorrectly, this is my first one on GitHub. Have a nice day.

@Arcovion
Copy link

See #1522, #1112, #1059 and #335.

@ghost
Copy link
Author

ghost commented May 24, 2014

Okay, do as you please but I will say that the uppercase doctype was required by xhtml and the lowercase version hightlights in red in many text-editors. I see no reason not to change it other than wanting the entire document to be lowercase which it isn't anyway.

@roblarsen
Copy link
Member

There's a lot of discussion in those previous issues. It's worth reading through, especially since the change back to lowercase was just last month.

@Arcovion
Copy link

All the other tags and attributes are lowercase though, personally I like it much more.
It sounds more like a problem with your editor than anything else, but it's true that it still tends to be that way and used to be the standard; Haml, Slim and Jade all return uppercase.

I don't think we can say much that hasn't been said already, it's NEVER mattered either way. One is a tradition, the other is consistent with all the other tags - unless you want to use uppercase for everything :P

@alrra
Copy link
Member

alrra commented May 24, 2014

many text-editors

@brianmillar9 can you be more specific? Thanks.

some IDEs and HTML Editors

@brianmillar9 thanks for the pull request, but will be sticking with lowercase. The highlighting problem represents a bug in the IDE/text editor, and thus, it should be fixed by them (if they haven't already)

@alrra alrra closed this May 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants