Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Meta Theme Colour Markup #1642

Closed
wants to merge 3 commits into from
Closed

Addition of Meta Theme Colour Markup #1642

wants to merge 3 commits into from

Conversation

mrwigster
Copy link

Added suggested meta tag: For Colour Bleed/theme colour on Chrome UI on
Android (inline with current colour bleed trends, such as Yosemite/iOS8
etc).

Addition of Meta Theme Colour Markup
b3bdd72 
Added suggested meta tag: For Colour Bleed/theme colour on Chrome UI on
Android (inline with current colour bleed trends, such as Yosemite/iOS8
etc).
@alrra
Copy link
Member

alrra commented Dec 4, 2014

IMHO, this should be included in the docs.

@arthurvr
Copy link
Member

arthurvr commented Dec 4, 2014

I agree with @alrra, and I'd opt for the docs (extend.md) too. We shouldn't provide a default on this, the default is specified by the browser itself.

For Colour Bleed/theme colour on Chrome UI on Android.

This is also implemented in Firefox OS 2.1.

Related issue in the mobile-bp repo: h5bp/mobile-boilerplate#234. There we'il go for extend.md too.

@mathiasbynens
Copy link
Member

+1 to @alrra and @arthurvr – this belongs in the docs.

Alex Wigmore added 2 commits December 5, 2014 12:52
Theme Colour meta tag details
f4f2380 
As suggested on this pull request:
#1642

Addition of theme colour meta markup to docs.
Support by chrome on Android and will be featured in upcoming Mozilla
releases.
Revert "Addition of Meta Theme Colour Markup"
937e4f9 
This reverts commit b3bdd72.
@mrwigster
Copy link
Author

As per feedback from @mathiasbynens, @alrra and @arthurvr, I have now switched this implementation to the extend docs as an optional meta title rather than a forced meta title.

alrra
alrra reviewed Dec 5, 2014
View reviewed changes
src/doc/extend.md
Android (inline with current colour bleed trends, such as Yosemite/iOS8
etc).

Content attribute should be a 6 digit hex code (at least for the moment, until official Moz docs are relased).

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@drublic drublic mentioned this pull request Dec 8, 2014
Closed
arthurvr referenced this pull request in arthurvr/bones Dec 20, 2014
added support for Chrome theme color
641e0bd 
more here:
http://updates.html5rocks.com/2014/11/Support-for-theme-color-in-Chrome-
39-for-Android
@arthurvr
Copy link
Member

arthurvr commented Jan 4, 2015

@mrwigster Bump. Can you address the above?

@alrra alrra mentioned this pull request Feb 5, 2015
Closed
18 tasks
alrra pushed a commit that referenced this pull request Feb 7, 2015
@alrra
Docs: Add info about <meta name="theme-color"...>
78c84ce 
Ref: https://github.com/whatwg/meta-theme-color
     https://bugzilla.mozilla.org/show_bug.cgi?id=1013913
     https://twitter.com/ahmednefzaoui/status/492344698493997057
     http://updates.html5rocks.com/2014/11/Support-for-theme-color-in-Chrome-39-for-Android

Close: #1642
@alrra
Copy link
Member

alrra commented Feb 7, 2015

Thanks @mrwigster.

@alrra alrra closed this Feb 7, 2015
eleanor-byhook pushed a commit to eleanor-byhook/html5-boilerplate that referenced this pull request Feb 29, 2016
@alrra
Docs: Add info about <meta name="theme-color"...>
6d94068 
Ref: https://github.com/whatwg/meta-theme-color
     https://bugzilla.mozilla.org/show_bug.cgi?id=1013913
     https://twitter.com/ahmednefzaoui/status/492344698493997057
     http://updates.html5rocks.com/2014/11/Support-for-theme-color-in-Chrome-39-for-Android

Close: h5bp/html5-boilerplate#1642
jeffreznik pushed a commit to jeffreznik/sw-test that referenced this pull request Oct 15, 2017
@alrra
Docs: Add info about <meta name="theme-color"...>
24b0db6 
Ref: https://github.com/whatwg/meta-theme-color
     https://bugzilla.mozilla.org/show_bug.cgi?id=1013913
     https://twitter.com/ahmednefzaoui/status/492344698493997057
     http://updates.html5rocks.com/2014/11/Support-for-theme-color-in-Chrome-39-for-Android

Close: h5bp#1642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting feedback documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrwigster @alrra @arthurvr @mathiasbynens