-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames main.js to app.js #2341
Conversation
looks good Rob- I think you need to run |
@coliff 👀 |
when I run I think we should set dependabot to ignore Modernizr updates - that should be updated manually as it requires a new build of H5Bp to be made. Otherwise we get issues like this... I'll look into that. |
Yeah, the latest modernizr is included here. We should look into it so that it's manual and not depdendabot driven, for sure. But this one was never updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising! Please have a look at the suggested change(s). Thank you! ✌️
@coliff dependabot have ignored_updates option which should solve that problem. The downside of doing this is that we need to be aware of bumping ignored package(s) manually 🤷♂️
|
@sthiepaan Since Modernizr is actually shipped with this project, I already watch it actively. |
I'll merge this tonight (GMT -04:00) |
closes #2340