Fixes 2012 + 2013 support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the manifest file to include support for both 2012 and 2013.
Added a strong name to all of the DLLs which are versioned by Visual Studio. This prevents builds of Encourage from incorrectly binding to later versions of the SDK. Correct builds must bind to the 2012 version of the SDK
These assemblies allow for builds on machines with 2013 only installed.
Fixed a couple of issues - The ReferencePath annotation must be absolute, not relative else MsBuild will error on some configurations - The reference to the shell needed to be 11.0 not 10.0
|
So if I build on my VS 2013 machine only and upload it, will that be fine? Or do I need to build it from a machine with both? |
|
@haacked it will work fine if built on a 2013 only machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues around the ability for Encourage to support Visual Studio 2012 and 2013
The first issue is updating the manifest file to include support for both versions. This is straight forward and just includes adding the necessary version numbers to source.extension.manifest.
The second is around ensuring the VSIX is built correctly. The previous solution reference all of the SDK DLLs using a weak name. This allowed them to bind equally well to 2012 and 2013 SDK versions of the DLLs. This works great if only 2012 or 2013 is installed on the machine. This is a problem however if both are installed.
When both 2012 and 2013 are installed the DLLs in the 2013 SDK are preferred over those in the 2012 SDK in MsBuild. The weak naming provides no preference between the two choices and hence the 2013 SDK wins. This means that building Encourage in 2012 would bind to the 2013 SDK which is wrong. We need Encourage to always bind to the 2012 SDK (else it will fail to load in VS 2012).
Fixing this comes in 2 parts
I tested this setup on machines with 2012 only, 2013 only and 2012 + 2013. Building and running from source worked on all 3 machines. I also took a build from the 2012 + 2013 machine and installed it from VSIX on the other two. Worked in all cases. If you want to play around with the built VSIX before uploading it's available here
https://onedrive.live.com/?cid=3B71B08E0FE95FC7&id=3B71B08E0FE95FC7%21128
CC'd @jbubriski