Remove javascript signatures from encouragement #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Javascript IDE implementation has a bug where by it will insert its signature help into any ISignatureHelpSession that is started. This includes the session that is started by the Enouragement extension. This causes encouragement tips to be intermixed with javascript signatures Due to the implementation of the Javascript provider the only suitable short term fix is to a) run after them and b) just remove their signatures from our session. This fixes #16 As a consequence it also fixes #1 as well.
haacked
added a commit
that referenced
this pull request
Jul 11, 2014
Remove javascript signatures from encouragement
|
Do you mean this also fixes #9 |
|
@haacked yes, that's what I get for typing up my commit messages without an internet connection 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Javascript IDE implementation has a bug where by it will insert its
signature help into any ISignatureHelpSession that is started. This
includes the session that is started by the Enouragement extension.
This causes encouragement tips to be intermixed with javascript
signatures
Due to the implementation of the Javascript provider the only suitable
short term fix is to a) run after them and b) just remove their
signatures from our session.
This fixes #16
As a consequence it also fixes #1 as well.