Remove Encouragement from Immediate Window #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encouragement was using the presence of an ITextDocument as the predicate for whether or not a given ITextView is eligible for encouragement tips Having an ITextDocument means a given ITextView is backed by a physical file and saving such an item should be encouraged. The problem is windows like the 'Immediate Window' are backed by physical files (esp with Roslyn). These files are implementation details though and saving them has no benefit to the user. In these cases the save operation isn't even directly surfaced to the user. It happens as a consequence of a non-save like action (in the case of the 'Immediate Window', it happens on every key stroke). This causes Encouragement to be displayed at unexpected times This change fixes this problem by changing the predicate slightly. We now check for ITextDocument (has ITextView has a physical backing file) and the Document role (this ITextView is being displayed as a document).
haacked
added a commit
that referenced
this pull request
Jul 18, 2014
Remove Encouragement from Immediate Window
|
|
|
Just released this as 1.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encouragement was using the presence of an ITextDocument as the
predicate for whether or not a given ITextView is eligible for
encouragement tips Having an ITextDocument means a given ITextView is
backed by a physical file and saving such an item should be encouraged.
The problem is windows like the 'Immediate Window' are backed by
physical files (esp with Roslyn). These files are implementation
details though and saving them has no benefit to the user. In these
cases the save operation isn't even directly surfaced to the user. It
happens as a consequence of a non-save like action (in the case of the
'Immediate Window', it happens on every key stroke). This causes
Encouragement to be displayed at unexpected times
This change fixes this problem by changing the predicate slightly. We
now check for ITextDocument (has ITextView has a physical backing file)
and the Document role (this ITextView is being displayed as a document).
closes #19