Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve today's date using the local timezone #128

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

kwbr
Copy link
Contributor

@kwbr kwbr commented Feb 1, 2024

This fixes #127.

I abstained from adding a test as I have not found out how to handle different timezones with Janet's os package. (https://github.com/cosmictoast/janet-date does provide more flexibility in this regard)

There might be other bugs lurking when converting the dates back and forth.

@strika
Copy link
Contributor

strika commented Feb 1, 2024

Looks good. Thanks. 👍

I don't remember why I didn't use janet-date. Maybe it wasn't available at the time or maybe it was missing something. In any case, I don't plan to adopt it at the moment.

@strika strika merged commit ba7e85c into hackberrydev:main Feb 1, 2024
1 check passed
@kwbr
Copy link
Contributor Author

kwbr commented Feb 2, 2024

Thanks for merging that. How can I build a binary for Mac? Is there a way to do that with docker?

@strika
Copy link
Contributor

strika commented Feb 2, 2024

Sorry, but I don't know about that. I'm primarily a Linux user. I use Docker on Linux. But I use an old Macbook Pro to build a binary for MacOS (x86_64). I don't use Docker when I do that.

If there is a way to build binaries for different systems on one platform, that would be great. Maybe you can ask at the Janet's forum - https://github.com/janet-lang/janet/discussions. Please tag me (if that's possible) if you do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong date when using --insert-days
2 participants