Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reminder that you don't need to close and remake your PR if you are asked to make a change in README #1401

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add reminder that you don't need to close and remake your PR if you are asked to make a change in README #1401

merged 2 commits into from
Nov 15, 2024

Conversation

alx-alexpark
Copy link
Member

No description provided.

@alx-alexpark alx-alexpark requested review from a team as code owners November 1, 2024 17:02
@alx-alexpark
Copy link
Member Author

cc: @grymmy, @Muirrum

@ajhalili2006
Copy link
Member

I think it should be amending an existing commit via git amend instead of adding another commit, as I experienced this on the Alpine Linux's ports repo, assuming that you do rebase-then-merge.

@alx-alexpark
Copy link
Member Author

alx-alexpark commented Nov 2, 2024 •
edited
Loading

Adding more commits should be fine

@alx-alexpark alx-alexpark enabled auto-merge (squash) November 15, 2024 00:15
@alx-alexpark alx-alexpark merged commit 6ca520e into main Nov 15, 2024
3 checks passed
@alx-alexpark alx-alexpark deleted the alx-alexpark-patch-1 branch November 15, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dispherical dispherical dispherical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alx-alexpark @ajhalili2006 @dispherical