Global nav #536
Merged
Global nav #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikguntner
requested review from
paulespinosa,
stevbark,
tylerthome,
ju1es,
agosmou,
rochun,
mira-kine,
edela0015 and
randelbrot
Screen.Recording.2023-07-11.at.8.14.22.PM.mov |
6 tasks
6 tasks
paulespinosa
requested changes
Jul 18, 2023
app/src/components/common/Header.tsx
Outdated
|
|
||
| function getInitials(name: string) { | ||
| const splitName = name.split(' '); | ||
| return splitName[0][0] + splitName[1][0]; |
There was a problem hiding this comment.
This should have more checks. For example, check if splitName has more than 1 element.
There was a problem hiding this comment.
@paulespinosa Thanks! Added a check for length and also to use the last element in case it's not just first and last name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following updates to the global nav bar:
We aren't currently collecting the user's name so right now it uses a fake name.