Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Fix/online events #34

Merged
merged 3 commits into from
May 12, 2020
Merged

Fix/online events #34

merged 3 commits into from
May 12, 2020

Conversation

ramonaspence
Copy link

The online events were not coming in because of the way they were being formatted into the event dictionary on lines 223 - 237. So I just made an it an if else statement, allowing the events with no venue_id be added to the dictionary.

The name of the days_in_the_past has been changed in the config.ini.example

@ramonaspence
Copy link
Author

I started to fix the block of code that defaults the start_date of the query to today so that it defaults to days_in_the_past

In the process, Flask is giving me a lot of small little errors (keyerrors, typeerrors) to work out before being able to debug further.

When I run the Flask app, I'm getting a consistent 500 response code, but I believe this only requires some refactoring of the app.

@ramonaspence
Copy link
Author

I've also fixed a couple of small TypeErrors that Flask did not like. The app now runs on a local server with status 200.

@allella allella merged commit f91a57a into hackgvl:master May 12, 2020
@allella
Copy link
Member

allella commented May 12, 2020

Cool. Squashed and merged this into this "upstream" master branch. That's the branch the production website is "tracking" so when I do a get pull on the master branch of the production site it will get this commit.

@allella
Copy link
Member

allella commented May 12, 2020

image

@allella
Copy link
Member

allella commented May 12, 2020

If you check out your local .git/config file you'll see the git mappings for origin and any "upstreams" you added.

In this case, I added a bcsnipes "upstream" when @bcsnipes was helping out, which allowed me to checkout a copy of his fork to test something and then switch back to the local master branch when I was done.

image

@ramonaspence
Copy link
Author

Neat! I'm starting to get the hang of it/ a good grasp on it!
I like the idea of making different/new branches for certain fixes then deleting them when the fix is complete/merged as suggested in the Chapter repo you sent me.

Although naming things clearly is vital and somehow really difficult lol!

@ramonaspence ramonaspence deleted the fix/online-events branch May 13, 2020 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants