Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Event future scope to sort events by active_at #384

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Update Event future scope to sort events by active_at #384

merged 1 commit into from
Aug 13, 2024

Conversation

bogdankharchenko
Copy link
Collaborator

No description provided.

@bogdankharchenko bogdankharchenko mentioned this pull request Aug 13, 2024
Closed
irby
irby approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@irby irby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIne by me. getActive is currently not used anywhere. I'd say we should axe that function if we're going to make the change here.

@bogdankharchenko bogdankharchenko merged commit f755b57 into develop Aug 13, 2024
1 check passed
@bogdankharchenko
Copy link
Collaborator Author

@irby I will think there is value in the test you wrote, I'll copy them over!

@irby irby mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irby irby irby approved these changes

@allella allella Awaiting requested review from allella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdankharchenko @irby