-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added small guide for auth #601
Conversation
Thanks a lot for this guide! Could you add a basic description of "What to do, to setup HackMD with provider XY"? Some kind of step by step guide for a provider of your choice :) |
@SISheogorath updated! added couple things to the README and config.json.example to include some s3 information as well |
To be honest I'm not the biggest fan of these changes. The Let me explain what I expect because that probably caused some confusion. We talk about the guide section, so we should guide new users to an auth provider. Let's take GitHub as an example: GitHubFirst of all, you need to sign up for a GitHub Account yourself and sign in to GitHub. Once that is done, check the OAuth section in the Developer Settings. Provide app name, callback URL and Homepage of your organization: Note: The callback URL is After registering the application, you get the Client ID and the Client Secret. Hint: Make your application more attractive by adding your organization's logo as app logo Put them into your
OR as environment variables on startup:
Restart HackMD and you can sign in using GitHub! I know this is a lot of work and this guide took me 20-30 minutes. But I don't expect to get all at once. It would be nice to get them one by one (of course you are also welcome to do them all ^^) but I think we should try to make it as easy as possible for people to adopt this. I hope this is not too much and you understand what is the goal. 😄 Cheers |
@SISheogorath apologies for the misunderstanding! thanks for providing an example, definitely is more clear of what you're looking for. will get something back up later this week / early next week. |
You can add the GitHub guide (feel free to extend it) as your work and add maybe another provider, too. To make it a bit easier I'll provide you the sources for the GitHub guide: https://hackmd.io/IYFg7AJgnARgZgJgLQEYRwMZJDAzLpYFCA6GUXAUwAYBWADmtyA=# |
179b2da
to
e8de18c
Compare
@SISheogorath updated for GitHub and Twitter docs |
Awesome @devonjs! Can we remove the non-verbose guides? With this done, we can merge it :) |
@SISheogorath updated! |
Thanks a lot! |
chore: bump AWS SDK from 2.345.0 to 2.521.0
Added most of the outcomes of the tickets marked
auth provider
, some of the tickets just needed a fix / not-valid. I couldn't come up with a great bulletpoint for this comment though: #141 (comment), wasn't sure how thedomain
property is completely used.Any suggestions to improving is welcome! I could've missed a few points for sure.