Add test to CharIO

[errordeveloper]

No description provided.

[farcaller]

Remove this line.

[farcaller]

assert!(io.getc() != '0');
assert!(io.getc() == 'a');

This double assertion doesn't make sense, the second line is enough.

io.puti(11);
assert!(io.getc() == '1');

This test, if done right, should check that putc is called twice with '1', otherwise it doesn't make much sense, checks with 3 and 9 are enough.

The test case puts_should_leave_us_with_just_the_last_char doesn't really check that much (while it does check the condition it's named after).

[errordeveloper]

@farcaller which one do you prefer:

fn getc(&self) -> char {
  self.lastchar.get()
}

or:

fn getc(&self) -> char {
  return self.lastchar.get();
}

[farcaller]

first one.

[errordeveloper]

@farcaller sure, I though of checking how many times putc was called, not quite sure how to check that though... perhaps I need to add a counter in TestCharIO struct and then a getter for it as well?

[errordeveloper]

I removed redundant assertions.

[errordeveloper]

RE puts_should_leave_us_with_just_the_last_char, you are right...
May be I could make one test that would call pust, check the last character and check how many times putc was called?

[farcaller]

perhaps I need to add a counter in TestCharIO struct and then a getter for it as well?

Yes, that's quite a good option.

[errordeveloper]

@farcaller I think this is going to be all part of #80 now... closing. Reopen if you want it separate.